[WIP] DeltaLog work
[WIP] = "Work in progress". Don't merge yet, since it both doesn't work and doesn't pass the linter and etc. I'm putting up the PR now so that MystK and whomever has the chance to comment on the WIP, if there's stylistic or functional problems with what I'm doing that are easier to address now that later.
I'll have one or two comments on specific bits in a sec, if anyone's looking.
Thanks for this @wyantb!
@mystk are you able to test this?
A few minor changes that come to my mind:
* When the OP hasn't awarded any deltas, the DeltaLog post should have "None yet." under the "deltas from OP" title.
* Can we distinguish every post made in /r/DeltaLog.
* I think 100 characters isn't quite enough, let's try 200?
And here's another idea that might not be minor:
In the event of a comment earning more than one delta, it would be good to compile it in the DeltaLog post like so:
* 3 deltas from /u/user1, /u/user2 and /u/user3 to /u/recipient for "This is the 200 character truncated comment..."
* 2 deltas from /u/user1 and /u/user2 to /u/recipient for "This is the 200 character truncated comment..."
* 4 deltas from /u/user1, /u/user2, /u/user3 and /u/user4 to /u/recipient for "This is the 200 character truncated comment..."
I will update staging with this. Do we have a deltalog dev subreddit? If not, could I request that you make one, @snorrrlax with the same name format as the CMV dev subreddit?
I'll make it just now: is /r/DeltaLogDB3Dev correct?
Yes that would be great thanks! (:
From: Snorrrlax [mailto:firstname.lastname@example.org]
Sent: Monday, January 2, 2017 2:05 PM
Cc: Antoine Pham
Subject: Re: [MystK/delta-bot-three] DeltaLog - initial implementation, ready for further testing (#105)
I'll make it just now: is /r/DeltaLogDB3Dev correct?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
, or mute the thread
Of the tweaks you suggested, two were trivial - increasing length to 200 and distinguishing the post (for the latter, assuming I did it right >.>. Just wrote it out raw without executing the code).
I think that both updating it to say "None Yet" and "3 posts from /u/blah1 /u/blah2" would take a little more work - I think I'd have to be able to split the sections of the post and deal with them a little more divergently (since if two users award userC a delta, but then OP also awards userC that delta, OP would go in a separate section. That's a bigger conditional branch than exists right now). So, that'd take a bit more time to work through all the kinks.
If you had a choice, would you rather I next work towards those small tweaks, or #89? (I'm going on vacation to NYC for a few days this week, and new job starts Monday - I'm guessing that my time is going to get cramped real quickly here. For whatever I don't get done, you might be best off assuming that someone else would need to tidy up the changes, with a chance we get lucky and I still have time)
@mystk I've created the subreddit and invited you as mod.
@wyantb in that case, I'd like to prioritise #89, and then move on to these changes if you have time. If not, hopefully someone else can pick it up.
OK, a basic form of the sticky comment is now in place as well. You can see something of the interaction and DeltaLog post changes from https://www.reddit.com/r/db3_wyantb/comments/5ls1l7/cmv_can_we_get_a_stick_comment_in_here_the_answer/ (I was prettifying the deltalog lines as I went along, so some of the links and newlines only got code improvements after the fact). You can also see how the internal page stores the format for posts that do/do not have deltas from OP (well, recorded ones, anyway, since those old posts won't get a sticky comment until OP makes another delta) in https://www.reddit.com/r/db3_wyantb/wiki/internal
Note, if we think this is good enough to roll out after testing, it'd make sense to file new issues for all the little things / improvements I glossed over for this MVP.
* "None yet" should be shown in the two deltalog post sections when there's no entries for that section
* A comment that receives multiple non-OP deltas should have all the awardees listed on the same log line
* The stickied comment is supposed to say "OP has awarded N deltas", whereas right now it says "OP has awarded at least one delta"
* ...other stuff I probably forgot...
For the stickied comment you linked, the "Delta System Explained | Deltaboards" footnote isn't on a new line, has this been fixed since testing?
Also I'd like to make a small change to the wording of that stickied comment:
> /u/wyantb (OP) has awarded at least one delta in this post.
> A compilation of deltas awarded (by OP and other users) can be found [here](https://www.reddit.com/r/db3_wyantb), in /r/db3_wyantb.
> Please note that a change of view is not necessarily a reversal, and that OP awarding a delta doesn't mean the conversation has ended.
> Delta System Explained | Deltaboards
Other than that, once @mystk or someone else has done further testing, it looks good to go!
Oh and I forgot:
Can we change the "is not necessarily a reversal" link to: https://www.reddit.com/r/changemyview/wiki/index#wiki_what_is_a_.27view.27.3F
And can we make "is not necessarily a reversal" a link in the stickied comment as well as the DeltaLog post.
String changes are easy, sure. Are you sure you want to link straight to the wiki portion on "what is a view" rather than "what is a change?" (And no, I missed having the "Delta System Explained" bit on a newline, so updated that in the same commit)
I think the context of "what is a view?" helps in understanding the next part. Thanks again, it's great to see this moving forward!