**NOTE**: For early review.
I'm confused. Isn't this pr for #948?
> I'm confused. Isn't this pr for #948?
I appreciate your politeness @r-marques as you are totally correct!
I don't think we can change the branch name.
Sorry for the troubles, it seems (see http://stackoverflow.com/a/20014444/2769475), we have two options:
* close this PR, and open a new one with the appropriate branch name; or
* keep this PR, knowing the branch name is incorrect, and misleading, but preserving the discussion
## [Current coverage](https://codecov.io/gh/bigchaindb/bigchaindb/pull/984?src=pr) is 96.31% (diff: 100%)
> Merging [#984](https://codecov.io/gh/bigchaindb/bigchaindb/pull/984?src=pr) into [master](https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr) will increase coverage by **0.06%**
@@ master #984 diff @@
Files 38 41 +3
Lines 1809 1843 +34
Methods 0 0
Messages 0 0
Branches 0 0
+ Hits 1741 1775 +34
Misses 68 68
Partials 0 0
> Powered by [Codecov](https://codecov.io?src=pr). Last update [29c10e3...9a9ca32](https://codecov.io/gh/bigchaindb/bigchaindb/compare/29c10e30a9b499f4b1e3c04edf706a79bac5c1ee...9a9ca329d5b9ec46a46a2e64b664b9c852611681?src=pr)
> but now the logic's being duplicated across two if statements in _configure_table()
def _configure_table(connection, table, *, replicas=None, shards=None):
if replicas is None or shards is None:
table_config = connection.run(r.table(table).config())
if replicas is None:
replicas = len(table_config['shards']['replicas'])
if shards is None:
shards = len(table_config['shards'])
connection, table, replicas=replicas, shards=shards)
> It's kind of a pain you have to be explicit about the other setting (e.g. you have to set replicas to be the same as before if you're only changing the shards); is this necessary @r-marques?
for the shards, we could use [`.config().update()`](https://www.rethinkdb.com/api/python/config/) I think.